Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error handling for auth0 source #3038

Merged
merged 7 commits into from
Feb 6, 2024
Merged

fix: error handling for auth0 source #3038

merged 7 commits into from
Feb 6, 2024

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Jan 29, 2024 •
edited
Loading

What are the changes introduced in this PR?

  • Throwing userId not present error when userId is missing in all the request in a batch.

What is the related Linear task?

Resolves INT-1140

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@Gauravudia Gauravudia requested a review from chandumlg January 29, 2024 12:00
@Gauravudia Gauravudia self-assigned this Jan 29, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@devops-github-rudderstack
Copy link
Contributor

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3038/test-report.html

1 similar comment
@devops-github-rudderstack
Copy link
Contributor

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3038/test-report.html

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7c3110) 84.48% compared to head (ee51b26) 87.14%.

❗ Current head ee51b26 differs from pull request most recent head c009f0c. Consider uploading reports for the commit c009f0c to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3038      +/-   ##
===========================================
+ Coverage    84.48%   87.14%   +2.65%     
===========================================
  Files          485      530      +45     
  Lines        26953    28806    +1853     
  Branches      6479     6859     +380     
===========================================
+ Hits         22772    25103    +2331     
+ Misses        3728     3360     -368     
+ Partials       453      343     -110

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia marked this pull request as ready for review January 31, 2024 04:57
@Gauravudia Gauravudia requested review from a team as code owners January 31, 2024 04:57
@devops-github-rudderstack
Copy link
Contributor

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3038/test-report.html

@devops-github-rudderstack
Copy link
Contributor

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3038/test-report.html

@devops-github-rudderstack
Copy link
Contributor

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3038/test-report.html

@devops-github-rudderstack
Copy link
Contributor

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3038/test-report.html

@devops-github-rudderstack
Copy link
Contributor

Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3038/test-report.html

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Gauravudia Gauravudia merged commit 2a21274 into develop Feb 6, 2024
12 checks passed
@Gauravudia Gauravudia deleted the fix/auth0-source-error-handling branch February 6, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihir-4116 mihir-4116 mihir-4116 approved these changes

@chandumlg chandumlg chandumlg approved these changes

@anantjain45823 anantjain45823 Awaiting requested review from anantjain45823 anantjain45823 is a code owner automatically assigned from rudderlabs/integrations

Assignees

@Gauravudia Gauravudia

Labels
Error refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravudia @devops-github-rudderstack @chandumlg @mihir-4116